Fix hanging on error (Issue #368)#370
Open
soryy708 wants to merge 1 commit intobrowserify:masterfrom
soryy708:master
Open
Fix hanging on error (Issue #368)#370soryy708 wants to merge 1 commit intobrowserify:masterfrom soryy708:master
soryy708 wants to merge 1 commit intobrowserify:masterfrom
soryy708:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#368
The error was swallowed, and the next pipe was never called, & the buffer was left open.
By emitting an error, the task crashes and prints the error, just like it was behaving in watchify 3.3.0 and prior.