Skip to content

Conversation

@drmick
Copy link
Member

@drmick drmick commented Jul 17, 2025

Collect validator events and provide per-block valid/invalid signature statistics over a block range

Pull Request Checklist

NODE CONFIGURATION MODEL CHANGES

None

BLOCKCHAIN CONFIGURATION MODEL CHANGES

None


COMPATIBILITY

Full

SPECIAL DEPLOYMENT ACTIONS

Not Required


PERFORMANCE IMPACT

No impact expected


TESTS

Unit Tests

Covered by:
cargo test --lib validator::event::collector::tests
cargo test --test validator_tests

Network Tests

[No coverage]

Manual Tests

transfers 10k


Notes/Additional Comments:

Added metrics to the Validator group

@github-actions
Copy link

github-actions bot commented Jul 17, 2025

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=823

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=823
  • Run specific test: gh workflow run network-tests.yml -f pr_number=823 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@drmick drmick changed the title merge Validator event listener Jul 17, 2025
@codecov
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

❌ Patch coverage is 50.87586% with 645 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.29%. Comparing base (fd0b611) to head (130e48e).

Files with missing lines Patch % Lines
slasher/src/collector/validator_events.rs 0.00% 180 Missing ⚠️
slasher/src/lib.rs 0.00% 143 Missing ⚠️
slasher/src/bc/stub_contract.rs 34.59% 101 Missing and 3 partials ⚠️
slasher/src/bc/mod.rs 37.80% 51 Missing ⚠️
slasher/src/storage/mod.rs 0.00% 41 Missing ⚠️
slasher-traits/src/validator.rs 74.17% 38 Missing and 1 partial ⚠️
slasher/src/storage/db.rs 0.00% 17 Missing ⚠️
slasher/src/util.rs 91.25% 10 Missing and 6 partials ⚠️
slasher/src/storage/models.rs 88.11% 6 Missing and 6 partials ⚠️
collator/src/validator/impls/std_impl/session.rs 77.55% 8 Missing and 3 partials ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #823      +/-   ##
==========================================
- Coverage   53.42%   53.29%   -0.13%     
==========================================
  Files         402      412      +10     
  Lines       68002    69291    +1289     
  Branches    68002    69291    +1289     
==========================================
+ Hits        36331    36931     +600     
- Misses      29685    30348     +663     
- Partials     1986     2012      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@drmick drmick force-pushed the feature/slasher branch 3 times, most recently from 0ef55ef to b132c83 Compare July 20, 2025 14:40
@drmick drmick changed the title Validator event listener Validator events collector Jul 20, 2025
@drmick drmick force-pushed the feature/slasher branch 2 times, most recently from 4061830 to 5b437f0 Compare July 20, 2025 15:27
@drmick drmick requested review from 0xdeafbeef, Rexagon and SmaGMan July 20, 2025 15:43
@drmick drmick marked this pull request as ready for review July 20, 2025 15:44
@drmick drmick linked an issue Jul 20, 2025 that may be closed by this pull request
@drmick drmick force-pushed the feature/slasher branch 3 times, most recently from 5c176b9 to 3723952 Compare July 22, 2025 16:34
Copy link
Member

@0xdeafbeef 0xdeafbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Rexagon Rexagon force-pushed the feature/slasher branch 4 times, most recently from 0ded3e5 to c4e8d05 Compare July 30, 2025 17:04
@SmaGMan SmaGMan marked this pull request as draft September 25, 2025 09:48
@Rexagon Rexagon force-pushed the feature/slasher branch 4 times, most recently from 9531911 to bd7f41e Compare November 28, 2025 17:20
@Rexagon Rexagon force-pushed the master branch 2 times, most recently from 746f7b5 to f541531 Compare December 5, 2025 12:16
@github-actions
Copy link

❌ CLI reference check failed in CI.

Please run just update_cli_reference, add the updated docs/cli-reference.md, and push the changes.

@github-actions
Copy link

❌ CLI reference check failed in CI.

Please run just update_cli_reference, add the updated docs/cli-reference.md, and push the changes.

@Rexagon Rexagon force-pushed the feature/slasher branch 2 times, most recently from c251180 to 1ef5f51 Compare December 25, 2025 16:48
@github-actions
Copy link

❌ CLI reference check failed in CI.

Please run just update_cli_reference, add the updated docs/cli-reference.md, and push the changes.

@Rexagon Rexagon force-pushed the feature/slasher branch 6 times, most recently from 25a9c9c to b203944 Compare January 20, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Collect validation stats and report them to Slasher component

6 participants