-
Notifications
You must be signed in to change notification settings - Fork 7
Validator events collector #823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🧪 Network TestsTo run network tests for this PR, use: gh workflow run network-tests.yml -f pr_number=823Available test options:
Test types: Results will be posted as workflow runs in the Actions tab. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #823 +/- ##
==========================================
- Coverage 53.42% 53.29% -0.13%
==========================================
Files 402 412 +10
Lines 68002 69291 +1289
Branches 68002 69291 +1289
==========================================
+ Hits 36331 36931 +600
- Misses 29685 30348 +663
- Partials 1986 2012 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0ef55ef to
b132c83
Compare
4061830 to
5b437f0
Compare
5c176b9 to
3723952
Compare
0xdeafbeef
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
0ded3e5 to
c4e8d05
Compare
c4e8d05 to
b3cfe8c
Compare
b3cfe8c to
e70a004
Compare
e70a004 to
8b37be4
Compare
9531911 to
bd7f41e
Compare
bd7f41e to
3d1159f
Compare
746f7b5 to
f541531
Compare
3d1159f to
ef19656
Compare
ef19656 to
3f65add
Compare
|
❌ CLI reference check failed in CI. Please run |
3f65add to
cafea1e
Compare
|
❌ CLI reference check failed in CI. Please run |
c251180 to
1ef5f51
Compare
|
❌ CLI reference check failed in CI. Please run |
b07cc98 to
910472f
Compare
25a9c9c to
b203944
Compare
b203944 to
500fb5e
Compare
500fb5e to
130e48e
Compare
Collect validator events and provide per-block valid/invalid signature statistics over a block range
Pull Request Checklist
NODE CONFIGURATION MODEL CHANGES
None
BLOCKCHAIN CONFIGURATION MODEL CHANGES
None
COMPATIBILITY
Full
SPECIAL DEPLOYMENT ACTIONS
Not Required
PERFORMANCE IMPACT
No impact expected
TESTS
Unit Tests
Covered by:
cargo test --lib validator::event::collector::testscargo test --test validator_testsNetwork Tests
[No coverage]
Manual Tests
transfers 10k
Notes/Additional Comments:
Added metrics to the
Validatorgroup