Refresh VS Code extension docs#2404
Conversation
Update the settings list, panels overview, and getting-started to match the current extension, and add Table Diff and Run History panel pages. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Prompt To Fix All With AIFix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
docs/vscode-extension/configuration.md:7
All other settings in this file use camelCase (e.g., `bruin.pathSeparator`, `bruin.cli.autoUpdate`), but `bruin.FoldingState` starts with an uppercase `F`. VS Code setting keys are case-sensitive when referenced directly in `settings.json`, so if the actual key is `bruin.foldingState` this would fail silently for anyone who tries to set it manually. Please verify the casing against the extension's `package.json` declaration.
```suggestion
- **Folding State** (`bruin.foldingState`): Whether Bruin sections are folded or expanded by default when you open an asset. Options: `folded`, `expanded`.
```
### Issue 2 of 2
docs/vscode-extension/configuration.md:32
A default of `1000` seconds (~16.7 minutes) for query timeout is unusually high. Could you confirm this is intentional and not meant to be milliseconds or a smaller number of seconds? If it is correct, a brief note explaining why (e.g. "suitable for large dataset queries") would help users calibrate their own settings.
Reviews (1): Last reviewed commit: "Refresh VS Code extension docs" | Re-trigger Greptile |
| ### General | ||
|
|
||
| Choose whether Bruin sections are folded or expanded by default when opening an asset. Adjust this in the extension settings under `Bruin > Default Folding State`. The options are: | ||
| - **Folding State** (`bruin.FoldingState`): Whether Bruin sections are folded or expanded by default when you open an asset. Options: `folded`, `expanded`. |
There was a problem hiding this comment.
All other settings in this file use camelCase (e.g.,
bruin.pathSeparator, bruin.cli.autoUpdate), but bruin.FoldingState starts with an uppercase F. VS Code setting keys are case-sensitive when referenced directly in settings.json, so if the actual key is bruin.foldingState this would fail silently for anyone who tries to set it manually. Please verify the casing against the extension's package.json declaration.
| - **Folding State** (`bruin.FoldingState`): Whether Bruin sections are folded or expanded by default when you open an asset. Options: `folded`, `expanded`. | |
| - **Folding State** (`bruin.foldingState`): Whether Bruin sections are folded or expanded by default when you open an asset. Options: `folded`, `expanded`. |
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/vscode-extension/configuration.md
Line: 7
Comment:
All other settings in this file use camelCase (e.g., `bruin.pathSeparator`, `bruin.cli.autoUpdate`), but `bruin.FoldingState` starts with an uppercase `F`. VS Code setting keys are case-sensitive when referenced directly in `settings.json`, so if the actual key is `bruin.foldingState` this would fail silently for anyone who tries to set it manually. Please verify the casing against the extension's `package.json` declaration.
```suggestion
- **Folding State** (`bruin.foldingState`): Whether Bruin sections are folded or expanded by default when you open an asset. Options: `folded`, `expanded`.
```
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
Verified against the extension's package.json (line 161): the key really is bruin.FoldingState with a capital F. It's an inconsistency in the extension itself, but the docs must match the actual key, so keeping it as-is — switching to foldingState would be the silent-failure case you flagged.
|
|
||
| The extension provides checkbox settings to control default enabled/disabled states for various features: | ||
| - **Preview Selected Query** (`bruin.query.previewSelectedQuery.enabled`): show the "Preview selected query" CodeLens when you select text in a SQL file. On by default. | ||
| - **Query Timeout** (`bruin.query.timeout`): timeout in seconds for query execution. Defaults to `1000`. |
There was a problem hiding this comment.
A default of
1000 seconds (~16.7 minutes) for query timeout is unusually high. Could you confirm this is intentional and not meant to be milliseconds or a smaller number of seconds? If it is correct, a brief note explaining why (e.g. "suitable for large dataset queries") would help users calibrate their own settings.
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/vscode-extension/configuration.md
Line: 32
Comment:
A default of `1000` seconds (~16.7 minutes) for query timeout is unusually high. Could you confirm this is intentional and not meant to be milliseconds or a smaller number of seconds? If it is correct, a brief note explaining why (e.g. "suitable for large dataset queries") would help users calibrate their own settings.
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
Confirmed intentional — it's in seconds. Added a note clarifying the unit and that the large default is deliberate (so big queries aren't cut off).
Add run options and backfill to the General tab docs, and a Commands & Shortcuts page covering the command palette actions and the preview shortcut. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Reviews (2): Last reviewed commit: "Document run options, backfill, and comm..." | Re-trigger Greptile |
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Reviews (3): Last reviewed commit: "Document variable overrides in the Gener..." | Re-trigger Greptile |
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Reviews (4): Last reviewed commit: "Clarify query timeout units in VS Code d..." | Re-trigger Greptile |
The VS Code extension docs had drifted from the current extension. This refresh:
configuration.mdwith the actual settings (folding, path separator, SQLFluff, CLI auto-update, telemetry, run-option defaults, sensor mode, query preview, query timeout, default exclude tag).panel-overview.mdandgetting-started.md(it said "two/three panels" and missed Table Diff and Run History).overview.md.