Skip to content

Fix ClickHouse delete+insert reruns#2424

Merged
karakanb merged 1 commit into
mainfrom
fix-issue-2420-with-tests
Jul 21, 2026
Merged

Fix ClickHouse delete+insert reruns#2424
karakanb merged 1 commit into
mainfrom
fix-issue-2420-with-tests

Conversation

@karakanb

Copy link
Copy Markdown
Contributor

What

Fix identical ClickHouse delete+insert reruns dropping rows when the replacement block is deduplicated.

Changes

  • Disable insert deduplication for ClickHouse delete+insert replacement inserts.
  • Add a ReplicatedMergeTree regression test, align its test configuration and module dependencies, and include required formatter output.

How to test

  1. make format
  2. make test
  3. make build-no-duckdb
  4. Run go test -count=1 -v . from integration-tests/cloud-integration-tests/clickhouse with Docker available.

Risk & rollback

  • Risk: Low; the setting only affects replacement inserts that follow Bruin-managed deletes.
  • Rollback: Revert the merge commit.

Checklist

  • Unit tests added or updated (make test)
  • Builds and lint pass (make build-no-duckdb, make format)
  • Integration tests pass if affected (make integration-test)
  • No unrelated changes included
  • Tested locally

Security

  • No secrets, credentials, or PII in this change
  • No new dependencies with known vulnerabilities
  • Security implications considered (if applicable)

Related issues

Closes #2420

Copy link
Copy Markdown
Contributor Author

@greptileai

@karakanb
karakanb merged commit 1fcdcfc into main Jul 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClickHouse delete+insert drops rows on an identical incremental rerun

2 participants