fix: Prevent URLSearchParams.toString() from returning unencoded params when not modified#292
Merged
andreiltd merged 2 commits intobytecodealliance:mainfrom Dec 16, 2025
Conversation
11053e6 to
b6a3979
Compare
…ms when not modified
b6a3979 to
c53ae31
Compare
andreiltd
reviewed
Dec 16, 2025
andreiltd
reviewed
Dec 16, 2025
andreiltd
approved these changes
Dec 16, 2025
Member
andreiltd
left a comment
There was a problem hiding this comment.
Thank you! I left some comments but mostly about the esthetics so feel free to resolve :-)
Contributor
Author
|
Done :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes spec compliance issue where
URLSearchParams.toString()incorrectly returned the raw unparsed query string from theURLobject if the params were not modified.The current implementation treats the
URLpassed toURLSearchParamsas the source of truth for the serialized query.This is incorrect because the URL parsing and
URLSearchParamsserialization use different encoding sets (query percent-encode setvsapplication/x-www-form-urlencoded).Echoing the raw query from url essentially bypasses the stricter serialization rules.
I added a lazy
serialized_query_cacheto hold the properly serialized query string. It will be populated duringtoString()calls (if empty) and invalidated whenever params are updated.This now makes 8 previously failing url related WPT tests pass.