Fix sock_connect using wrong rights constant#4849
Open
sumleo wants to merge 1 commit intobytecodealliance:mainfrom
Open
Fix sock_connect using wrong rights constant#4849sumleo wants to merge 1 commit intobytecodealliance:mainfrom
sumleo wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
wasi_ssp_sock_connect checks __WASI_RIGHT_SOCK_BIND instead of __WASI_RIGHT_SOCK_CONNECT when validating file descriptor rights. This was a copy-paste error from wasi_ssp_sock_bind. As a result, connect operations check the wrong capability.
sumleo
requested review from
TianlongLiang,
lum1n0us,
no1wudi and
yamt
as code owners
TianlongLiang
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wasi_ssp_sock_connectinposix.cchecks__WASI_RIGHT_SOCK_BINDinstead of__WASI_RIGHT_SOCK_CONNECTwhen validating file descriptor rights viafd_object_get. This was a copy-paste error from the adjacentwasi_ssp_sock_bindfunction.As a result,
sock_connectoperations validate the wrong capability on the file descriptor — checking for bind rights rather than connect rights.Fix
Changed the rights constant from
__WASI_RIGHT_SOCK_BINDto__WASI_RIGHT_SOCK_CONNECTin thefd_object_getcall withinwasi_ssp_sock_connect.Test plan
wasi_ssp_sock_bindfunction still correctly uses__WASI_RIGHT_SOCK_BINDwasi_ssp_sock_connectwas changed