Open
Conversation
francislavoie
approved these changes
Jan 11, 2024
Member
francislavoie
left a comment
francislavoie
left a comment
There was a problem hiding this comment.
LGTM, just would like @carlwgeorge's review.
carlwgeorge
reviewed
Feb 9, 2024
Collaborator
carlwgeorge
left a comment
carlwgeorge
left a comment
There was a problem hiding this comment.
As discussed in #107, TasksMax isn't available in RHEL 7's systemd version. To adopt this as is we would need to drop RHEL 7 as a targeted OS, which is a decision for the project maintainers. Alternatively, we can just remove LimitNPROC instead, as there is some question if it is really needed.
Member
|
Yeah, let's drop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #107
TasksMaxis supported since systemd 227 which got released back in 2015.