nexus: add cursor theme selector to wallpaper & style page#1563
Open
vitormarquesgithub wants to merge 5 commits into
Open
nexus: add cursor theme selector to wallpaper & style page#1563vitormarquesgithub wants to merge 5 commits into
vitormarquesgithub wants to merge 5 commits into
Conversation
…sing - Add sanitize() function to strip unsafe characters from theme names - Pass theme name as positional argument ($1) instead of concatenating into shell command to prevent injection - Remove unused 'loaded' property - Ensure qmlformat compliance
- Replace cut -d' ' -f3 with sed 's/.*= *\//' in currentProc for robust parsing regardless of spacing around '=' - Add grep check before sed in applyProc to handle missing variable, falling back to appending to the config
vitormarquesgithub
force-pushed
the
feature/cursor-theme-selector
branch
from
c0f699e to
be6d403
Compare
Contributor
|
This might be something to hold off on a bit, as I think instead of adding too many toplevel options there, might be a subpage of "colours and style" where this functionality can sit as a single dropdown selector. |
Author
Makes sense, happy to rework it as a dropdown inside a Colours and Style subpage. Should I wait for maintainer input on the exact structure before refactoring, or do you have a design in mind? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a cursor theme selector sub-page to the Wallpaper & style page in the nexus settings.
What this adds
/usr/share/icons,~/.local/share/iconsand~/.iconshyprctl setcursorandgsettings$cursorThemeviasedNotes
$cursorThemein the Hyprland variables configDemo
cursor-theme.mp4