feat: responsive 2-column Wi-Fi list on wide panels#1601
Open
Mestane wants to merge 1 commit into
Open
Conversation
Mestane
force-pushed
the
feat/wifi-responsive-columns
branch
from
95a14e0 to
a466f7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional columns property to
ItemList(default 1 keeps the existing single-columnListViewunchanged; >1 switches to aGridView). The Wi-Fi network list now shows two columns on panels wider than 620px and one column below that, so wide layouts use the horizontal space better.The delegate sizes itself to the view (grid cell or full row width) instead of anchoring to the list's content item.
Important
I’m creating all the PRs as separate patch series so they stay independent and are easier to manage. Because of that, there will likely be changes to the PRs. For now, please don’t start reviewing any of them. I’ll let you know when they’re ready.
Note
Also, I’d appreciate it if you could avoid merging anything into the main branch for at least a week.