feat: Emit suggested_replacement with the json error format#5831
Open
feat: Emit suggested_replacement with the json error format#5831
suggested_replacement with the json error format#5831Conversation
Contributor
…fixes-for-some-diagnostics
…fixes-for-some-diagnostics
Changed the error format type from Classic to Plain in flags.ml and updated related argument parsing in args.ml. Adjusted message printing in diag.ml to reflect the new default error format.
Kamirus
commented
Feb 19, 2026
| } | ||
| type edit = { | ||
| at_edit : Source.region; | ||
| suggested_replacement : string; |
Contributor
Author
There was a problem hiding this comment.
It is cleaner to have edits separate from spans because there is no priority nor label here.
It's easier to remember when serializing into diagnostics format to handle edits differently
…fixes-for-some-diagnostics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit machine-applicable code fixes in
--error-format jsondiagnostics for warnings M0223 (redundant type instantiation), M0236 (use dot notation), and M0237 (omit explicit implicit argument). The JSON span format now includesis_primary,label,suggested_replacement, andsuggestion_applicabilityfields, enabling IDEs and tooling to offer automatic fixes