Generalized namespaces, added limits and other workers#52
Open
ashahab wants to merge 1 commit intocaicloud:masterfrom
Open
Generalized namespaces, added limits and other workers#52ashahab wants to merge 1 commit intocaicloud:masterfrom
ashahab wants to merge 1 commit intocaicloud:masterfrom
Conversation
caicloud-bot
added
release-note-none
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Travis tests have failedHey @ashahab, 1st Buildgometalinter --config=linter_config.json --vendor ./...goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/kernel/*.go"2nd Buildgometalinter --config=linter_config.json --vendor ./...goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/kernel/*.go"3rd Buildgometalinter --config=linter_config.json --vendor ./...goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/kernel/*.go"TravisBuddy Request Identifier: d8274990-caa8-11e8-bd56-bd6e450aa6f6 |
gaocegege
reviewed
Oct 8, 2018
|
|
||
| FROM alpine:3.7 | ||
| MAINTAINER Ce Gao <gaoce@caicloud.io> | ||
| FROM docker.artifactory-test.corp.linkedin.com/tensorflow/lipy-relevance-image-hdfs:0.1.404 |
Contributor
There was a problem hiding this comment.
We cannot get the image from Linkedin's private registry, so I think we cannot update the code here.
| "fmt" | ||
| "log" | ||
|
|
||
| "os" |
Contributor
There was a problem hiding this comment.
Here should be placed in the first section.
| @@ -1,3 +1,3 @@ | |||
| kubeconfig: /var/run/kubernetes/admin.kubeconfig | |||
| kubeconfig: /var/run/kubernetes/tensorflow.corp-ltx1.kubeconfig | |||
Contributor
There was a problem hiding this comment.
This is the default config template, then I think we should keep admin
| import ( | ||
| "fmt" | ||
|
|
||
| "os" |
Contributor
There was a problem hiding this comment.
Same here, os should be placed in the first section.
| "k8s.io/api/core/v1" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
|
|
||
| "k8s.io/apimachinery/pkg/api/resource" |
Contributor
There was a problem hiding this comment.
The third party package should be placed in the second section.
| filename := fmt.Sprintf("/%s/%s", parameter.Image, s2iconfigmap.FileName) | ||
|
|
||
| image_name := os.Getenv("IMAGE_NAME") | ||
| cpu_image_name := os.Getenv("CPU_IMAGE_NAME") |
Contributor
There was a problem hiding this comment.
name here should be camel case.
| WorkerPrefix: "%worker=", | ||
| PSPrefix: "%ps=", | ||
| MasterPrefix: "%master=", | ||
| WorkerPrefix: "kf_worker=", |
Contributor
There was a problem hiding this comment.
I think there is no need to change % to kf_ since % is the convention in the community.
Contributor
|
/cc @ddysher |
caicloud-bot
added
the
needs-rebase
Contributor
|
@ashahab: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
|
Issues go stale after 90d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with /lifecycle stale |
caicloud-bot
added
the
lifecycle/stale
Contributor
|
@ashahab Thanks for the PR! I will implement the feature based on your awesome work, since it seems that you have no time to update it. |
Author
|
Actually I do have time next week if you are fine waiting. This is an
awesome project, I'd like to contribute.
…On Thu, Mar 21, 2019, 11:35 PM Ce Gao ***@***.***> wrote:
@ashahab <https://github.com/ashahab> Thanks for the PR! I will implement
the feature based on your awesome work, since it seems that you have to
time to update it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#52 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAqJPVd17-veS6EVhm4lxpVFjpRED-S2ks5vZHnHgaJpZM4XMMPt>
.
|
Contributor
|
@ashahab OK Welcome your contribution! Of course, I can wait for you. I am a little busy in the past six months while now I think I have time to maintain the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add your description
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #
Special notes for your reviewer:
/cc @your-reviewer
Release note: