-
Notifications
You must be signed in to change notification settings - Fork 0
Stephenhung/rep 32 auth create reset password flow #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stephenhungg
wants to merge
21
commits into
main
Choose a base branch
from
stephenhung/rep-32-auth-create-reset-password-flow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Stephenhung/rep 32 auth create reset password flow #19
stephenhungg
wants to merge
21
commits into
main
from
stephenhung/rep-32-auth-create-reset-password-flow
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create AuthContext.tsx in utils folder with AsyncStorage persistence - Wrap app with AuthProvider in _layout.tsx - Add login/signup integration with context - Create dashboard page for authenticated users - Implement stay signed in feature with checkbox - Add smart routing based on authentication state - Include loading states and error handling - All code formatted with prettier
- Add landing page with logo, welcome text, and login/signup buttons - Update signup page to match Figma design with logo, updated styling, and password requirements with checkmarks - Update login page to match Figma design and be consistent with signup - Download and add all necessary assets (logos, checkmarks, landing image) - Fix linting errors by converting require() to ES6 imports - Fix ScrollView padding to prevent excessive scrolling - Ensure consistent styling across all auth pages
- Add .tsx files to ESLint config files array - Disable @typescript-eslint/no-require-imports rule for React Native/Expo image imports - Image imports use valid ES6 syntax but were incorrectly flagged by the linter
…rep-32-auth-create-reset-password-flow
- Extract all inline styles to authStyles.ts - Add utility styles: scrollViewFlex, scrollViewContent, textBlack, forgotPasswordLink, etc. - Replace inline style objects with stylesheet references across all auth pages - Keep dynamic styles (opacity, borderColor) inline where needed - Improves code maintainability and follows React Native best practices
- Remove .pids/expo.log and .pids/rails.log from git tracking - These files are already in .gitignore but were tracked before the rule was added - Local files remain on filesystem, just not tracked by git
- Create dedicated styles.ts for my-account page - Extract all 26 inline styles to stylesheet - Add semantic style names: avatarContainer, fieldBox, logoutButton, etc. - Improves code readability and maintainability - Follows React Native best practices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Description
Screenshots
How to review
Next steps
Relevant links
Online sources
Related PRs
CC: @insert pl github username here