Skip to content

Docker File Update#300

Open
Manav-bin wants to merge 3 commits intocalebstewart:masterfrom
Manav-bin:master
Open

Docker File Update#300
Manav-bin wants to merge 3 commits intocalebstewart:masterfrom
Manav-bin:master

Conversation

@Manav-bin
Copy link
Copy Markdown

Description of Changes

Replaced the Alpine-based multi-stage Docker build with a Debian python:3.9-slim multi-stage build to improve compatibility with prebuilt wheels, reduce build complexity, and avoid musl-related compilation issues.

Fixes #XXX.

Please note any noqa: comments needed to appease flake8.

Major Changes Implemented:

  • Replaced python:3.9-alpine base images with python:3.9-slim for both builder and final stages
  • Removed Alpine-specific dependencies (apk, alpine-sdk, musl-dev, linux-headers, etc.)
  • Added Debian equivalents (build-essential, libffi-dev, libssl-dev, cargo) in the builder stage
  • Simplified artifact copying by copying /usr/local from the builder stage into the final stage
  • Limited runtime dependencies in final stage to libstdc++6 only
  • Retained plugin pre-download step (pwncat-cs --download-plugins) in final stage

Pre-Merge Tasks

  • [x ] Formatted all modified files w/ python-black
  • Sorted imports for modified files w/ isort
  • Ran flake8 on repo, and fixed any new problems w/ modified files
  • Ran pytest test cases
  • Added brief summary of updates to CHANGELOG (under [Unreleased])

Alpine was giving issues, so updated to slim.
Also, removed the dependency on apk bec ew.
Added instructions for using pwncat from anywhere in the filesystem with a shell function.
Updated the README to emphasize using a function for pwncat and added benefits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant