mediatypes: detect utf-8 encoded JSON manifest#113
mediatypes: detect utf-8 encoded JSON manifest#113steveej wants to merge 1 commit intocamallo:masterfrom
Conversation
|
This is a bug in Satellite, as While I don't have problems landing this PR as a temporary fix, I would really like to first have a ticket to track on Satellite side to fix it (and some timebox to remove this hack). |
|
I filed a BZ ticket for this: https://bugzilla.redhat.com/show_bug.cgi?id=1749317 |
This is returned by the Satellite registry.
steveej
force-pushed
the
pr/mediatype-detect-utf8-applicationjson
branch
from
fbe80da to
9d33035
Compare
|
I think I misunderstood your comment. Do I understand correctly now that the content-type is actually contradicting in itself? |
steveej
changed the title
Yes. That said, I'm fine with either landing this band-aid or do #83 and relax the parser, as long Satellite gets fixed at some point. |
If getting a 404 response when calling 'has_manifest' then if the content-type returned for the json error body is 'application/json; charset=utf-8' then the call to 'evaluate_media_type' will fail because it does not expect charset=utf-8 to be valid here. see discussion in: camallo#113 This change follows the approach taken in other methods above which is to match on 'status' before continuing.
If getting a 404 response when calling 'has_manifest' then if the content-type returned for the json error body is 'application/json; charset=utf-8' then the call to 'evaluate_media_type' will fail because it does not expect charset=utf-8 to be valid here. see discussion in: camallo#113 This change follows the approach taken in other methods above which is to match on 'status' before continuing.
2 participants
This is returned by the Satellite registry.