Open
Conversation
Collaborator
Author
|
Replacing #271 which was closed unexpectedly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/OTA-1552
From the CI test:
there are 7 tests failing in our CI job.
net::docker_io::test_dockerio_anonymous_authis fixed by #269 and the remained six are fixed by this PR.The trick of getting an image for
application/vnd.docker.distribution.manifest.v1+prettyjwswhich is required bynet::quay_io::test_quayio_auth_manifest:dkregistry-rs/tests/net/quay_io/mod.rs
Line 221 in 8e021d0
I tried with GPG sign with podman
podman push --sign-by hongkliu@redhat.com quay.io/openshift-ota/cincinnati-test:0.0.1 --authfile /tmp/hk.jsonbut it did not work.So I noticed this PUBLIC image:
dkregistry-rs/tests/net/quay_io/mod.rs
Lines 202 to 207 in 8e021d0
and check with
Great. It has the expected type. Then I copied the image over and
net::quay_io::test_quayio_auth_manifestbecomes green.$ skopeo copy --dest-authfile /tmp/hk.json docker://quay.io/coreos/alpine-sh:latest docker://quay.io/openshift-ota/cincinnati-test:0.0.1Other changes in the PR are the adjustments for the new image.
Hindsight is that it is very unlikely we have this type of images for OpenShift releases: neither
cosignnorgpgsigns images with that type. But maybe other projects relies on this. So keeping the type of image in the test intact might be a good idea.