Fixing the dst type, which is expected to be *mut i8#195
Open
dmikushin wants to merge 2 commits intocameleon-rs:mainfrom
Open
Fixing the dst type, which is expected to be *mut i8#195dmikushin wants to merge 2 commits intocameleon-rs:mainfrom
dmikushin wants to merge 2 commits intocameleon-rs:mainfrom
Conversation
245 | std::ptr::copy_nonoverlapping(self.as_ptr().cast::<i8>(), dst, self.len());
| ----------------------------- ^^^ expected `*mut i8`, found `*mut u8`
| |
| arguments to this function are incorrect
bschwind
reviewed
Nov 1, 2024
Co-authored-by: Matěj Laitl <matej@laitl.cz>
Contributor
|
This probably now just needs another code formatting run, and a rebase on the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for your hard work on cameleon, this is a great project!
This trivial PR fixes an error occured during my compilation, possibly with a newer version of Rust compiler:
Changelog
*mut u8to*mut i8instd::ptr::copy_nonoverlapping.