Skip to content

Simplify MetaPlaylist Manifest loading by relying on the same code than other transports #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peaBerberian wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Simplify MetaPlaylist Manifest loading by relying on the same code than other transports #1487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 0 additions & 74 deletions src/transports/metaplaylist/manifest_loader.ts
View file
Open in desktop

This file was deleted.

12 changes: 8 additions & 4 deletions src/transports/metaplaylist/pipelines.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ import type {
ITransportOptions,
ITransportPipelines,
} from "../types";
import generateManifestLoader from "./manifest_loader";
import generateManifestLoader from "../utils/generate_manifest_loader";

/**
* Get base - real - content from an offseted metaplaylist content.
Expand Down Expand Up @@ -112,9 +112,13 @@ function getMetaPlaylistPrivateInfos(segment: ISegment): IMetaPlaylistPrivateInf
export default function (options: ITransportOptions): ITransportPipelines {
const transports: Partial<Record<string, ITransportPipelines>> = {};

const manifestLoader = generateManifestLoader({
customManifestLoader: options.manifestLoader,
});
const manifestLoader = generateManifestLoader(
{
customManifestLoader: options.manifestLoader,
},
"text",
null,
);

// remove some options that we might not want to apply to the
// other streaming protocols used here
Expand Down
Loading