Open
Conversation
00fc806 to
b7216b4
Compare
c0a3466 to
d66ff3d
Compare
d66ff3d to
eb1454b
Compare
eb1454b to
ade0ad6
Compare
ade0ad6 to
67030a2
Compare
0182497 to
bfe3a20
Compare
6d4fed2 to
9b856a5
Compare
bfe3a20 to
55c05a8
Compare
fb9f7ed to
13be225
Compare
6cfd206 to
1e55170
Compare
a42734c to
29372ac
Compare
13be225 to
20ef8ec
Compare
d4be192 to
9ad6758
Compare
0142e34 to
1fd9df3
Compare
20ef8ec to
fbfaaef
Compare
|
✅ Automated performance checks have passed on commit DetailsPerformance tests 1st run outputNo significative change in performance for tests:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: To facilitate tests, I deployed that work on the https://developers.canal-plus.com/rx-player/mpd-chaining demo page
This is a very naive implementation of the DASH Manifest chaining concept which allows to signal a next content to load from the first content's MPD. Use cases we've heard of are mainly pre-roll or post-roll contents (basically ad before and after a content) including for live contents.
I only handle the chaining at the end of the previous content for now. There is a second situation "Fallback Chaining" which is supposed to do so at the "failure" of a content that I do not yet handle as it poses much more questions in terms of RxPlayer API.
Even in that very simple chaining after ENDED, there is still some API question left: should we send an event when chaining? What loadVideo options should we set, should we ask the application? How can an application configure the start time of one of the chained content?
To note also that some other players preload the future content at the end of the previous one with the goal of having a lower transition time, I saw mainly the shaka-player with this. The RxPlayer has no preload concept yet.