Skip to content

feat: upstream --project flag for remote-build#634

Merged
bepri merged 14 commits intomainfrom
work/add-project-to-remote-build/CRAFT-4044
Feb 7, 2025
Merged

feat: upstream --project flag for remote-build#634
bepri merged 14 commits intomainfrom
work/add-project-to-remote-build/CRAFT-4044

Conversation

@bepri
Copy link
Member

@bepri bepri commented Feb 6, 2025

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?
  • Have you added an entry to the changelog (docs/reference/changelog.rst)?

@bepri bepri requested review from lengau and mr-cal February 6, 2025 15:41
@bepri bepri self-assigned this Feb 6, 2025
@bepri bepri marked this pull request as ready for review February 6, 2025 15:41
Copy link
Contributor

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

As discussed in standup, I can't test this locally until you put up the Snapcraft PR that refactors onto this command with the changes here and in #632. Once you have that up, I'll test it!

Copy link
Contributor

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also OK if you pre-emptively land these. You can always make another PR if testing in Snapcraft exposes any bugs.

@bepri bepri merged commit c5e963e into main Feb 7, 2025
15 checks passed
@bepri bepri deleted the work/add-project-to-remote-build/CRAFT-4044 branch February 7, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants