docs: explain how to remove errored apps in k8s tutorial#2445
docs: explain how to remove errored apps in k8s tutorial#2445gcomneno wants to merge 3 commits intocanonical:mainfrom
Conversation
tonyandrewmeyer
left a comment
There was a problem hiding this comment.
The "juju refresh will not work" isn't really true, because in the tutorial we say to use --force-units, which ignores the error state.
I'm also not sold on suggesting remove-application here, because you're either about to deploy it for the first time (if something went wrong, we should have advice for fixing that after the deploy step), or it's deployed and you're refreshing, in which case we are suggesting removing without suggesting deploying again.
@gcomneno did you have this problem, or are you just working on the PR because there is an open issue for it? If you had the problem, did you try using --force-units, and it failed?
@dwilding you opened the linked issue - did you experience this or get feedback from someone working through the tutorial?
In general, I would prefer that we encourage people to use --force-units and resolve than teach them that they should reach for --force as a first step. A 'remove and redeploy' is ok, but I think there are methods people should be trying before that too.
|
Thanks, that makes sense. I did not hit this personally while working through the tutorial — I picked it up based on the open issue and followed the problem statement there. So yes, this change was based on the issue report rather than on a reproduction from my side. You are right that my wording is too absolute, especially given the existing I will hold off on pushing a revised version until we get clarification from @dwilding on the scenario they had in mind, unless you would prefer that I just trim this back now and remove the |
|
@dwilding opened the issue after discussion with me. An onboarder I was mentoring encountered this after getting a charm into a bad state, after which The current formatting of the command in the docs somewhat hides the flag: I wonder if we should reformat to something like this in all cases (need to test that Juju is happy with the options ordered like this, and that it doesn't linebreak awkwardly in the docs): And perhaps add a tip after the first use of |
|
Thanks @james-garner-canonical - I talked to David about this today but hadn't had a chance to reach out to you yet (busy day!). I think rearranging to emphasise force-units, and a tip that suggest it and explains what it does sound like good ideas. I've rather avoid the remove-deploy pattern unless we hear that force-units is breaking (and even then, I would rather talk to the Juju folk first). I think we ought to be able to do the rearranging in each chapter, but I think the tip in just the first one would be sufficient. |
|
Updated the tutorial as discussed:
Validated locally with:
|
tonyandrewmeyer
left a comment
There was a problem hiding this comment.
Thanks @gcomneno ! I think this will help people, and if there are any continuing issues we should look into what's going wrong before adjusting the docs.
|
Thanks Tony — glad this looks helpful. Agreed: if people keep running into issues here, it’s better to understand what’s actually going wrong in Juju before we make the docs more prescriptive. Happy to tweak anything else if needed. |
|
Thanks again for the review and approval. Just checking in: from my side this looks ready, but please let me know if there is anything else you’d like me to adjust before merge. |
Summary
juju refreshwon't work when the app is inawaiting error resolutionjuju remove-application fastapi-demo --forcein that situationIssue