test(react): increase coverage for Slider#21837
Draft
adamalston wants to merge 1 commit intocarbon-design-system:mainfrom
Draft
test(react): increase coverage for Slider#21837adamalston wants to merge 1 commit intocarbon-design-system:mainfrom
adamalston wants to merge 1 commit intocarbon-design-system:mainfrom
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21837 +/- ##
==========================================
+ Coverage 87.75% 87.78% +0.03%
==========================================
Files 536 536
Lines 43637 43631 -6
Branches 6696 6719 +23
==========================================
+ Hits 38293 38301 +8
+ Misses 5193 5179 -14
Partials 151 151
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I don't plan to mark this pull request as ready for review until some of my earlier pull requests have been reviewed. I want to avoid diverting attention from them. Otherwise, these changes are ready to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No issue.
Increased test coverage for
Sliderand deleted unreachable code.Changelog
Changed
Slider.Removed
Testing / Reviewing
yarn test --coverage \ --runTestsByPath packages/react/src/components/Slider/__tests__/Slider-test.js \ --collectCoverageFrom=packages/react/src/components/Slider/Slider.tsxPR Checklist
As the author of this PR, before marking ready for review, confirm you:
Updated documentation and storybook examplesAddressed any impact on accessibility (a11y)Tested for cross-browser consistencyMore details can be found in the pull request guide