feat(cds-dialog): new preview component#21853
Open
maradwan26 wants to merge 23 commits intocarbon-design-system:mainfrom
Open
feat(cds-dialog): new preview component#21853maradwan26 wants to merge 23 commits intocarbon-design-system:mainfrom
maradwan26 wants to merge 23 commits intocarbon-design-system:mainfrom
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21853 +/- ##
==========================================
- Coverage 94.39% 94.39% -0.01%
==========================================
Files 536 536
Lines 43679 43682 +3
Branches 6278 6285 +7
==========================================
+ Hits 41231 41233 +2
- Misses 2309 2310 +1
Partials 139 139
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adamalston
reviewed
Mar 18, 2026
packages/web-components/src/components/dialog/dialog.stories.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
|
maradwan26
requested review from
a team and
anishapatroibm
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20539
Closes #20973
Adds new preview component
cds-dialogto Carbon Web Components, matching its React counterpart preview__Dialog.Changelog
New
cds-dialog,cds-dialog-title,cds-dialog-footer, etc. and respective logic, styles, and storiesprevent-close-on-click-outsidesince it's also in modal as I figured users would expect to find it here toopreview__CDSDialog,preview__CDSDialogTitle, etc. from the centralindex.tsaria-labelandaria-labelledbyChanged
modal.tsto allow for overridingbutton.scssto supportcds-dialog-footer-buttonresizeObserverand also remove the gradient when the container is small viacds--dialog-scroll-content--no-fade. This matches the implementation inModalandComposedModalariaLabel,ariaLabelledBy, andariaDescribedByin favour ofaria-label,aria-labelledby, andaria-describedbyrespectivelyElement with "region" role does not have a labelTesting / Reviewing
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
[ ] Wrote passing tests that cover this change