Skip to content

fix/docs:add a comment in-place where something maybe wrong #6752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nameearly wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

fix/docs:add a comment in-place where something maybe wrong #6752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions common/filesystem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,6 +730,9 @@ auto MakeTmpDirWithPrefix(std::filesystem::path prefix)

// The permissions must be exactly 0700 for a temporary directory, and the UID
// should be ours.
// Note: The `&&` below only rejects the directory when *both* the permissions
// and the UID are unexpected. If the intended security requirement is to
// reject when *either* differs, this condition would need to use `||`.
if (stat.permissions() != 0700 && stat.unix_uid() != geteuid()) {
return Error(
llvm::formatv("Found incorrect permissions or UID on tmpdir '{0}'",
Expand Down
Loading