Change "FromHere" error messages to be a more direct error#6807
Open
danakj wants to merge 7 commits intocarbon-language:trunkfrom
Open
Change "FromHere" error messages to be a more direct error#6807danakj wants to merge 7 commits intocarbon-language:trunkfrom
danakj wants to merge 7 commits intocarbon-language:trunkfrom
Conversation
Contributor
Author
|
First new commit is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These messages used to be annotation notes. Now they are error messages. However they are in a position where they require some
ErrorContextto exist (type completion internals requireCheckHasContextto be true), so we do know they will end up being transformed into notes. Regardless, as they are errors, phrase them in terms of a failure instead of as an annotation.Depends on #6806