Fix _FakeDoneEvent.signal_evt class-state leakage between XMPP tests#1529
Merged
caronc merged 2 commits intoxmpp-test-race-condition-fixfrom Feb 20, 2026
Merged
Conversation
5 tasks
Co-authored-by: caronc <850374+caronc@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update test to prevent XMPP racing condition failures
Fix _FakeDoneEvent.signal_evt class-state leakage between XMPP tests
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_FakeDoneEvent.signal_evtwas set via direct class attribute assignment in three timeout-path tests, leaving stale state that could affect subsequent tests depending on execution order.Changes
_FakeDoneEvent.signal_evt = ...direct assignments withmonkeypatch.setattr()so pytest's monkeypatch fixture automatically restores the attribute to its originalNoneafter each test🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.