Replace magic number in _FakeDoneEvent with named constant#1530
Merged
caronc merged 2 commits intoxmpp-test-race-condition-fixfrom Feb 20, 2026
Merged
Replace magic number in _FakeDoneEvent with named constant#1530caronc merged 2 commits intoxmpp-test-race-condition-fixfrom
_FakeDoneEvent with named constant#1530caronc merged 2 commits intoxmpp-test-race-condition-fixfrom
Conversation
5 tasks
…ELAY Co-authored-by: caronc <850374+caronc@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on preventing XMPP racing condition test failures
Replace magic number in Feb 20, 2026
_FakeDoneEvent with named constant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pre_waitclass attribute on_FakeDoneEventused a bare0.02float with no explanation of why that specific duration was chosen, making the intent opaque.Changes
WORKER_THREAD_STARTUP_DELAY: float = 0.02defined at module level intests/test_plugin_xmpp.py, with a comment explaining it exists to give the worker thread enough time to reach a known checkpoint before the test forces the timeout branch — without adding unnecessary wall-clock overhead to the test suite._FakeDoneEvent.pre_waitnow referencesWORKER_THREAD_STARTUP_DELAYinstead of the inline literal.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.