Skip to content

Use lang from config for code chunks output #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Bisaloo wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Use lang from config for code chunks output #645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion R/build_episode.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,9 @@ build_episode_md <- function(path, hash = NULL, outdir = path_built(path),
spinner = sho,
env = c(callr::rcmd_safe_env(),
"RENV_PROFILE" = profile,
"RENV_CONFIG_CACHE_SYMLINKS" = renv_cache_available())
"RENV_CONFIG_CACHE_SYMLINKS" = renv_cache_available(),
"LANGUAGE" = get_config()$lang,
Copy link
Contributor Author

@Bisaloo Bisaloo Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not completely sure if we should rely on get_config()'s default arg here, or provide another value?

I'd welcome any insights on this, or I will investigate more myself once #644 have been decided.

Copy link
Contributor Author

@Bisaloo Bisaloo Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the failing checks seem to have answered this. A different value is needed. The default only works for the standard setup.

)
)

invisible(outpath)
Expand Down
Loading