Fixed using EditableInput in shadow DOM. - #811
Open
Nuurek wants to merge 1 commit into
Open
Conversation
|
I really need this. |
|
You can implement a temporary workaround while this PR is waiting to be merged:
|
itzhari1996
approved these changes
Apr 10, 2023
vijayjangid
approved these changes
Apr 12, 2023
|
@casesandberg what's the likelihood of getting this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I tried to use
react-colorinside of a Shadow DOM then none of the text inputs worked. Digging down into the code I found this single line that was trying to access the active element from the top-leveldocument.In such a scenario:
where the node of
custom-web-componentis the Shadow Root,document.activeElementwas returning the Shadow Root node. Changing it togetRootNode()returns correct active elements and inputs start working.