Skip to content

fix: reassign utility part slots#8551

Draft
scarf005 wants to merge 1 commit intocataclysmbn:mainfrom
scarf005:fix/8489/expand-vehicle-part-slots
Draft

fix: reassign utility part slots#8551
scarf005 wants to merge 1 commit intocataclysmbn:mainfrom
scarf005:fix/8489/expand-vehicle-part-slots

Conversation

@scarf005
Copy link
Copy Markdown
Member

Purpose of change (The Why)

Closes #8489.
Vehicle utility parts were still sharing the legacy anywhere slot, which blocked combinations like foldable seats with NBC seals on the same tile.

Describe the solution (The How)

Reassign former anywhere parts to more specific layers (center, on_ceiling, on_roof) and give on_ceiling explicit ordering.
Add regression tests for the slot remap and for installing utility parts on a folding-seat tile.

Testing

  • cmake --build --preset linux-full --target astyle
  • cmake --build --preset linux-full --target style-json-parallel
  • cmake --build --preset linux-full --target cata_test-tiles
  • ./out/build/linux-full/tests/cata_test-tiles "vehicle_part_utility_slots_are_not_anywhere"
  • ./out/build/linux-full/tests/cata_test-tiles "folding_seat_tile_accepts_other_utility_parts"
  • ./build-scripts/lint-json.sh

Additional context

No existing docs appear to cover vehicle part slot layering.

Checklist

Mandatory

Optional

  • This is a C++ PR that modifies JSON loading or behavior.
  • I have documented the changes in the appropriate location in the docs/ folder.
  • If documentation for this feature does not exist, please write it or at least note its lack in PR description.

PR opened by gpt-5.4 high on opencode

Assisted-by: openai/gpt-5.4 on opencode
Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
@github-actions github-actions Bot added src changes related to source code. JSON related to game datas in JSON format. tests changes related to tests labels Apr 17, 2026
"item": "sheet",
"folded_volume": "2500 ml",
"location": "anywhere",
"location": "center",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one defeats the main purpose of foldable seats, being used like a hammock tucked into any passable tile to make it one that can be sat at, assign NPCs to, etc. Maybe on_ceiling on the basis of being hung from the ceiling I guess?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

JSON related to game datas in JSON format. src changes related to source code. tests changes related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand vehicle part slots

2 participants