Draft
Conversation
Assisted-by: openai/gpt-5.4 on opencode Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
chaosvolt
reviewed
Apr 17, 2026
| "item": "sheet", | ||
| "folded_volume": "2500 ml", | ||
| "location": "anywhere", | ||
| "location": "center", |
Member
There was a problem hiding this comment.
This one defeats the main purpose of foldable seats, being used like a hammock tucked into any passable tile to make it one that can be sat at, assign NPCs to, etc. Maybe on_ceiling on the basis of being hung from the ceiling I guess?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of change (The Why)
Closes #8489.
Vehicle utility parts were still sharing the legacy
anywhereslot, which blocked combinations like foldable seats with NBC seals on the same tile.Describe the solution (The How)
Reassign former
anywhereparts to more specific layers (center,on_ceiling,on_roof) and giveon_ceilingexplicit ordering.Add regression tests for the slot remap and for installing utility parts on a folding-seat tile.
Testing
cmake --build --preset linux-full --target astylecmake --build --preset linux-full --target style-json-parallelcmake --build --preset linux-full --target cata_test-tiles./out/build/linux-full/tests/cata_test-tiles "vehicle_part_utility_slots_are_not_anywhere"./out/build/linux-full/tests/cata_test-tiles "folding_seat_tile_accepts_other_utility_parts"./build-scripts/lint-json.shAdditional context
No existing docs appear to cover vehicle part slot layering.
Checklist
Mandatory
closes #1234in Summary of the PR so it can be closed automatically.mainso it won't cause conflict when updatingmainbranch later.Optional
docs/folder.PR opened by gpt-5.4 high on opencode