👷‍♀️ Clang windows builds to solidify it as a real platform!#3064
Open
ThePhD wants to merge 4 commits into
Open
👷‍♀️ Clang windows builds to solidify it as a real platform!#3064ThePhD wants to merge 4 commits into
ThePhD wants to merge 4 commits into
Conversation
Codecov Reportâś… All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #3064 +/- ##
=======================================
Coverage 91.34% 91.34%
=======================================
Files 202 202
Lines 8869 8869
=======================================
Hits 8101 8101
Misses 768 768 🚀 New features to boost your workflow:
|
horenmar
reviewed
Feb 4, 2026
horenmar
reviewed
Feb 4, 2026
Member
That does not look like Clang. |
dfca25e to
40b31af
Compare
Contributor
Author
|
This is now looking like clang, finally: ...
-- The CXX compiler identification is Clang 20.1.8 with GNU-like command-line
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files/LLVM/bin/clang++.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
... |
rajpratham1
approved these changes
Jul 11, 2026
rajpratham1
left a comment
There was a problem hiding this comment.
This looks like a useful addition. Expanding CI to cover Clang on Windows strengthens support for a platform/compiler combination that can expose issues not seen with MSVC or Linux Clang. The workflow builds both Debug and Release configurations across multiple language standards and runs the full test suite, making it a low-risk infrastructure improvement. Assuming the existing runner image continues to provide clang++ as expected, this looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI for Clang. On Windows!! With a new file.
Description
In my last pull request (#3060), it was said I should make Clang a Real Platform™️ by putting it in the CI. That's what this does!