Add album cover rounding functionality#271
Conversation
|
Ahah I actually made this on my side but didn't do a PR. It looks nice, but I think you should put the setting in the Album cover section. |
|
Ooh, yeah, I should've probably done that already. Will do in a moment! |
There was a problem hiding this comment.
Looks good to me, good job! I left only a minor comment for the config variable name.
Can you rebase onto master and regenerate the translations files? (https://github.com/ccatterina/plasmusic-toolbar?tab=readme-ov-file#translations)
Thank you! 🙂
|
I hope this is better? |
Yeah, the translation generation script uses msgmerge, which auto-generates fuzzy translations, and they're quite bad. I need to change the script to avoid autogenerating them 🙂. @Nicolas-Gth, since you wrote the translation file, could you please review the French translations? Thanks! |
…#269) * Added an option to hide the album name if it is identical to the track title for both full and compact representations * Add colons to the end of the new config options * Recompiled translations * Update src/contents/ui/config/Full.qml Co-authored-by: Claudio Catterina <ccatterina@proton.me> * Update src/contents/ui/config/Compact.qml Co-authored-by: Claudio Catterina <ccatterina@proton.me> * Recompiled translations again --------- Co-authored-by: Claudio Catterina <ccatterina@proton.me>
|
|
||
| #: src/contents/ui/config/Full.qml:229 | ||
| #, fuzzy, kde-format | ||
| msgid "Album cover radius" |
There was a problem hiding this comment.
Why english version doesn't have : ?
There was a problem hiding this comment.
Ah, I must've read this commit 46b5b35 and (incorrectly) assumed it was for all labels, apologies
Will fix in a sec
| #: src/contents/ui/config/Full.qml:218 | ||
| #, fuzzy, kde-format | ||
| msgid "Round album cover" | ||
| msgstr "Afficher la pochette" |
There was a problem hiding this comment.
"Round album cover" translation would be "Pochette d'album arrondie"
There was a problem hiding this comment.
May I assume that the fuzzy-matched translation for "Album cover radius" is correct?
There was a problem hiding this comment.
Yes it sounds alright to me
|
@Trip7274 Can you rebase on to |
# Conflicts: # src/translate/fr.po # src/translate/it.po # src/translate/nl.po # src/translate/template.pot # src/translate/tr.po # src/translate/uk.po
|
Thank you @Trip7274 , great job! 🚀 |
4 participants
Hello!
I felt that, since the outer frame around the full applet view can be rounded, it can be quite jarring for the album art to be razor sharp, so I tried implementing that functionality.
I'm not too experienced in QML, so I tried to follow what the rest of the code did for other image rounding functionality, I hope it's good!
The corner radius is toggle-able and adjustable 2-26px (in 2px increments)
Images:
Before + un-backgrounded album art:
Before + backgrounded album art:
After + un-backgrounded:
After + backgrounded: