fix: align song text in panel on song change#282
Open
Nicolas-Gth wants to merge 2 commits intoccatterina:mainfrom
Open
fix: align song text in panel on song change#282Nicolas-Gth wants to merge 2 commits intoccatterina:mainfrom
Nicolas-Gth wants to merge 2 commits intoccatterina:mainfrom
Conversation
Owner
|
Hi @Nicolas-Gth , I gave it a try but sometimes the song text overlap with the commands and I keep getting binding loop errors. |
Contributor
Author
That is strange. But I agree I see a lot of issues linked to it, so good luck! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #267 introduced a circular width dependency in the panel text layout:
ScrollingTextwas changed from explicitwidth+Layout.preferredWidthtoLayout.fillWidth: true, which meant the text container's width was assigned by the parent layout rather than computed from the text content. On song change, the centering position was calculated from the stale (previous song) width and never updated.Here's my fix:
Instead of resizing the text box to fit the content and then centering it, the text box now always takes up all available space and the text is centered visually inside it.
Also fixes a binding loop on
animationRunning/textin ScrollingText.qml.This should fix #280