Skip to content

fix: align song text in panel on song change#282

Open
Nicolas-Gth wants to merge 2 commits intoccatterina:mainfrom
Nicolas-Gth:fix/panel-song-text-alignment-on-song-change
Open

fix: align song text in panel on song change#282
Nicolas-Gth wants to merge 2 commits intoccatterina:mainfrom
Nicolas-Gth:fix/panel-song-text-alignment-on-song-change

Conversation

@Nicolas-Gth
Copy link
Copy Markdown
Contributor

@Nicolas-Gth Nicolas-Gth commented Mar 18, 2026

PR #267 introduced a circular width dependency in the panel text layout: ScrollingText was changed from explicit width + Layout.preferredWidth to Layout.fillWidth: true, which meant the text container's width was assigned by the parent layout rather than computed from the text content. On song change, the centering position was calculated from the stale (previous song) width and never updated.

Here's my fix:

Instead of resizing the text box to fit the content and then centering it, the text box now always takes up all available space and the text is centered visually inside it.

Also fixes a binding loop on animationRunning/text in ScrollingText.qml.

This should fix #280

@ccatterina
Copy link
Copy Markdown
Owner

Hi @Nicolas-Gth , I gave it a try but sometimes the song text overlap with the commands and I keep getting binding loop errors.
I noticed that the ScrollingText component has become really hard to maintain and I was thinking to rewrite it completely.
I’ll try to tackle it next week.

@Nicolas-Gth
Copy link
Copy Markdown
Contributor Author

Hi @Nicolas-Gth , I gave it a try but sometimes the song text overlap with the commands and I keep getting binding loop errors.
I noticed that the ScrollingText component has become really hard to maintain and I was thinking to rewrite it completely.
I’ll try to tackle it next week.

That is strange. But I agree I see a lot of issues linked to it, so good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Song text alignment in panel view bugged after 4.0.0 update

2 participants