feat: support default notify config for alert rules (#2871) #2910
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
What this PR does / why we need it:
This PR implements support for default notify configurations in alert notification rules.
currently, when an alert is triggered, if none of the notify configs match the alert's conditions (severity, time range, etc.), no notification is sent. This can lead to missed alerts in edge cases.
This PR adds an
IsDefaultfield to NotifyConfig, allowing users to designate one config as a fallback. The new logic works as follows:This ensures critical alerts are neevr silently dropped due to misconfigured matching rules.
Which issue(s) this PR fixes:
Fixes #2871