Improve reconnect specs to cover all three bug fixes - #3
Open
doctorfred wants to merge 1 commit into
Open
Conversation
doctorfred
force-pushed
the
fix/reconnect-spec-improvements
branch
2 times, most recently
from
April 13, 2026 19:51
5b0900a to
26950cf
Compare
Rewrite the reconnect specs per maintainer feedback: - Test orphaned acks using real publish(qos: 1) in a thread instead of reaching into internal queue - Add spec for reconnect_limit=nil (nil.zero? crash) - Add spec for wake_up_pipe read_nonblock race condition 706 examples, 0 failures, 97.9% coverage.
doctorfred
force-pushed
the
fix/reconnect-spec-improvements
branch
from
April 13, 2026 21:35
26950cf to
9c30898
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2 — rewrites the reconnect specs per your feedback:
publish("test/topic", "payload", qos: 1)in a second thread instead of reaching into internal queue. Polls@acksfor registration rather than sleeping.nil.zero?no longer crashes when reconnect_limit is nil (unlimited retries).read_nonblockdoesn't block when the pipe has already been drained by another thread.706 examples, 0 failures, 97.9% line coverage.