Conversation
simPod
force-pushed
the
php81
branch
3 times, most recently
from
e31fa54 to
f638ca2
Compare
|
@cebe I've resolved conflict |
| * @return boolean true on success or false on failure. | ||
| * The return value will be casted to boolean if non-boolean was returned. | ||
| */ | ||
| #[\ReturnTypeWillChange] |
There was a problem hiding this comment.
given that this library is not compatible with PHP 5, as far as I see it would be better to make return types compatible instead of adding the annotation which only hides the deprecation warning but does not actually fix the problem.
see https://php.watch/versions/8.1/internal-method-return-types
There was a problem hiding this comment.
just seen that this is what #143 does, will check that in more detail later.
There was a problem hiding this comment.
I intended this as a middle step in order to keep BC.
After this there's #143 to be merged
|
Is there any update about this PR. I would really need it 😅 |
|
Hi, I want to avoid forking, thought about contributing, but I see fix is already here. Can I do anything to speed up 8.1 compatibility being merged? |
|
Upvote for this one to be merged sooner than later. Thanks! |
|
waiting for this one to be merged too |
|
I merged a different solution in #162, thanks for your contribution anyway! |
6 participants
Replaces #143 that should be merged to php-openapi version that does not support old PHP versions.