Skip to content

rgw/admin: Add support for rate-limits#1256

Merged
mergify[bot] merged 1 commit intoceph:masterfrom
sj14:sj/rgw-ratelimits
Apr 17, 2026
Merged

rgw/admin: Add support for rate-limits#1256
mergify[bot] merged 1 commit intoceph:masterfrom
sj14:sj/rgw-ratelimits

Conversation

@sj14
Copy link
Copy Markdown
Contributor

@sj14 sj14 commented Apr 10, 2026 •
edited
Loading

Add support for setting individual bucket rate limits and receiving them again.

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview
  • Ran make api-update to record new APIs

New or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.

The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with @Mergifyio rebase to rebase your PR when github indicates that the PR is out of date with the base branch.

@sj14 sj14 force-pushed the sj/rgw-ratelimits branch 3 times, most recently from a3f0639 to 090d3e5 Compare April 10, 2026 11:46
@sj14 sj14 marked this pull request as ready for review April 10, 2026 12:23
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 10, 2026

This pull request now has conflicts with the target branch.
Could you please resolve conflicts and force push the corrected
changes? 🙏

@sj14 sj14 force-pushed the sj/rgw-ratelimits branch from 090d3e5 to fbea0c3 Compare April 11, 2026 09:19
@phlogistonjohn
Copy link
Copy Markdown
Collaborator

phlogistonjohn commented Apr 13, 2026

TestRadosGWTestSuite/TestLink/link_test-user2
failure on quincy could be related to this change. The other test failures are CI issues that should be solved next time you rebase.

@sj14 sj14 force-pushed the sj/rgw-ratelimits branch 2 times, most recently from f837b6d to eefd9c6 Compare April 14, 2026 10:40
@sj14
Copy link
Copy Markdown
Contributor Author

sj14 commented Apr 14, 2026 •
edited
Loading

Fixed the issue with quincy but the pacific pipeline just seems to be incredibly slow.

@phlogistonjohn
Copy link
Copy Markdown
Collaborator

phlogistonjohn commented Apr 14, 2026

@Mergifyio rebase

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 14, 2026

Deprecation notice: This pull request comes from a fork and was rebased using bot_account impersonation. This capability will be removed on July 1, 2026. After this date, the rebase action will no longer be able to rebase fork pull requests with this configuration. Please switch to the update action/command to ensure compatibility going forward.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 14, 2026

rebase

✅ Branch has been successfully rebased

phlogistonjohn
phlogistonjohn reviewed Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks fine to me, but I am not strong on RGW. We should get at least one review from somone more well versed in RGW.

cc: @anoopcs9 @thotz

@phlogistonjohn
Copy link
Copy Markdown
Collaborator

phlogistonjohn commented Apr 14, 2026

The pacific jobs seems to be getting stuck on one or more go package dependencies. Seems odd.

anoopcs9
anoopcs9 requested changes Apr 15, 2026
View reviewed changes
Comment thread testing/containers/micro-osd.sh Outdated
@sj14 sj14 force-pushed the sj/rgw-ratelimits branch from 3f9b69a to ef8a9ab Compare April 15, 2026 10:56
@anoopcs9
Copy link
Copy Markdown
Collaborator

anoopcs9 commented Apr 15, 2026

@Mergifyio rebase

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 15, 2026

rebase

✅ Branch has been successfully rebased

@anoopcs9 anoopcs9 force-pushed the sj/rgw-ratelimits branch from ef8a9ab to 2109ef9 Compare April 15, 2026 14:31
anoopcs9
anoopcs9 requested changes Apr 16, 2026
View reviewed changes
Comment thread rgw/admin/bucket_rate_limit_test.go Outdated
Comment thread rgw/admin/bucket_rate_limit_test.go Outdated
Comment thread rgw/admin/bucket_rate_limit.go
Comment thread rgw/admin/bucket_rate_limit_test.go Outdated
@sj14 sj14 force-pushed the sj/rgw-ratelimits branch from 2109ef9 to 354e72f Compare April 16, 2026 14:32
anoopcs9
anoopcs9 requested changes Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@anoopcs9 anoopcs9 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not noticing it earlier. Since we also have a CI job running against the pacific version, it must be included in the build tags. Therefore, the tag format should be:
//go:build !(pacific || quincy) && ceph_preview.

Again, sorry for the inconvenience.

@sj14 sj14 force-pushed the sj/rgw-ratelimits branch from 354e72f to e66741a Compare April 17, 2026 06:32
@anoopcs9
Copy link
Copy Markdown
Collaborator

anoopcs9 commented Apr 17, 2026

@Mergifyio rebase

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 17, 2026

rebase

✅ Branch has been successfully rebased

@anoopcs9 anoopcs9 force-pushed the sj/rgw-ratelimits branch from e66741a to f2d55cb Compare April 17, 2026 07:29
anoopcs9
anoopcs9 approved these changes Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for your patience 🙂.

@anoopcs9 anoopcs9 requested a review from phlogistonjohn April 17, 2026 08:52
@anoopcs9 anoopcs9 requested a review from thotz April 17, 2026 08:52
@phlogistonjohn
Copy link
Copy Markdown
Collaborator

phlogistonjohn commented Apr 17, 2026

@Mergifyio rebase

@sj14 @phlogistonjohn
rgw/admin: Add support for rate-limits
2cb59cc 
Add support for setting individual bucket rate limits and receiving
them again.

Signed-off-by: Simon Jürgensmeyer <simon.juergensmeyer@hetzner-cloud.de>
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 17, 2026

rebase

✅ Branch has been successfully rebased

@phlogistonjohn phlogistonjohn added the API This PR includes a change to the public API of a go-ceph package label Apr 17, 2026
@mergify mergify bot added the queued label Apr 17, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 17, 2026 •
edited
Loading

Merge Queue Status

  • ✅ Entered queue — 2026-04-17 12:51 UTC · Rule: default
  • ✅ Checks skipped · PR is already up-to-date
  • ✅ Merged — 2026-04-17 12:51 UTC · at 2cb59cc39b1ae16c70abc4f7e8fd7687b4d61daf · rebase

This pull request spent 9 seconds in the queue, including 1 second running CI.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = check
    • check-neutral = check
    • check-skipped = check
  • any of [🛡 GitHub branch protection]:
    • check-success = test-suite (pacific)
    • check-neutral = test-suite (pacific)
    • check-skipped = test-suite (pacific)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-suite (quincy)
    • check-neutral = test-suite (quincy)
    • check-skipped = test-suite (quincy)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-suite (reef)
    • check-neutral = test-suite (reef)
    • check-skipped = test-suite (reef)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-suite (squid)
    • check-neutral = test-suite (squid)
    • check-skipped = test-suite (squid)

@mergify mergify bot merged commit d377045 into ceph:master Apr 17, 2026
15 of 16 checks passed
@mergify mergify bot removed the queued label Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anoopcs9 anoopcs9 anoopcs9 approved these changes

@phlogistonjohn phlogistonjohn phlogistonjohn approved these changes

@thotz thotz Awaiting requested review from thotz

Assignees

No one assigned

Labels

API This PR includes a change to the public API of a go-ceph package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sj14 @phlogistonjohn @anoopcs9