Skip to content

nfs: add ApplyExportInfo function#1261

Open
nixpanic wants to merge 3 commits intoceph:masterfrom
nixpanic:nfs/export-update
Open

nfs: add ApplyExportInfo function#1261
nixpanic wants to merge 3 commits intoceph:masterfrom
nixpanic:nfs/export-update

Conversation

@nixpanic
Copy link
Copy Markdown
Member

Add ApplyExportInfo function to update existing NFS exports using the
'nfs export update' command prefix.

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview
  • Ran make api-update to record new APIs

Copy link
Copy Markdown
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, an old TODO fulfilled. LGTM.

@phlogistonjohn phlogistonjohn added the API This PR includes a change to the public API of a go-ceph package label Apr 17, 2026
@phlogistonjohn phlogistonjohn requested a review from anoopcs9 April 17, 2026 14:29
Copy link
Copy Markdown
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the typo, changes lgtm.


// applyRes is used to parse the result from "nfs export apply" which can
// modify multiple exports with a single call. Each export that was (attempted
// to be) modified has JSON resonse with "pseudo" and "state" in it.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// to be) modified has JSON resonse with "pseudo" and "state" in it.
// to be) modified has JSON response with "pseudo" and "state" in it.

@phlogistonjohn
Copy link
Copy Markdown
Collaborator

@Mergifyio rebase

Add ApplyExportInfo function to update existing NFS exports using the
'nfs export update' command prefix.

Assisted-By: AskBob <askbob@ibm.com>
Signed-off-by: Niels de Vos <ndevos@ibm.com>
Assisted-By: AskBob <askbob@ibm.com>
Signed-off-by: Niels de Vos <ndevos@ibm.com>
Signed-off-by: Niels de Vos <ndevos@ibm.com>
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 17, 2026

Deprecation notice: This pull request comes from a fork and was rebased using bot_account impersonation. This capability will be removed on July 1, 2026. After this date, the rebase action will no longer be able to rebase fork pull requests with this configuration. Please switch to the update action/command to ensure compatibility going forward.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 17, 2026

rebase

✅ Branch has been successfully rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API This PR includes a change to the public API of a go-ceph package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants