Fix issues around Xcode 16, and rename to parse(...) from init(...)#133
Open
rinsuki wants to merge 1 commit intocezheng:masterfrom
Open
Fix issues around Xcode 16, and rename to parse(...) from init(...)#133rinsuki wants to merge 1 commit intocezheng:masterfrom
rinsuki wants to merge 1 commit intocezheng:masterfrom
Conversation
We shouldn't depends to pointer is still valid after withUnsafe~'s callback is end. but `convenience init` will not allow us to call self.init inside of withUnsafe~'s callback, this is why we need to rename to parse(...) from init(...)
Stormy242
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We shouldn't depends to pointer is still valid after withUnsafe~'s callback is ended (and Xcode 16's swiftc finally breaks it).
but
convenience initwill not allow us to call self.init from withUnsafe~'s callback, so there are two options: