[Suggestion] create updateAttr method on XMLElement#75
Open
GeekTree0101 wants to merge 1 commit intocezheng:masterfrom
Open
[Suggestion] create updateAttr method on XMLElement#75GeekTree0101 wants to merge 1 commit intocezheng:masterfrom
GeekTree0101 wants to merge 1 commit intocezheng:masterfrom
Conversation
Owner
|
I have thought about supporting modifying XML before, but this will require a major rewrite since the current implementation heavily relies on For this PR, the attributes property will be broken. |
Author
|
Okey I got it, thanks for code review :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needs update attribute value on XMLElement,
If you don't mind, Please check it
Thank you