refactor: add missing mts ext. support to checkly config#1019
refactor: add missing mts ext. support to checkly config#1019
mts ext. support to checkly config#1019Conversation
|
Are you sure that the current changes are enough? I don't think this works without changing checkly-cli/packages/cli/src/services/checkly-config-loader.ts Lines 77 to 97 in 9072477 Without adding Additionally Either way I wouldn't really call this a refactor. I would like you to change this to feat instead because that's what it is, and it should therefore come with at least 1 test to prove that it works, or at minimum you must provide some proof that it worked for you locally. |
|
Also I would like to know the motivation for this change. I agree that it's good but just wondering what made you think of doing it. |
I hereby confirm that I followed the code guidelines found at engineering guidelines
Affected Components
Notes for the Reviewer
Currently the CLI is able to read both JS/TS files, or
.mjswhen the app is declared ascommonjsand needs to be interpreted as a ESM; but is missing the ability to do so when the config is written in TypeScript.This PR adds the
.mtsextension to the list of candidates to read the config from to allow certain settings like https://www.typescriptlang.org/tsconfig/#verbatimModuleSyntax to work while in commonjs apps.