Issue #14782: Add LITERAL_DEFAULT token support in RightCurlyCheck#19037
Open
vivek-0509 wants to merge 1 commit intocheckstyle:masterfrom
Open
Issue #14782: Add LITERAL_DEFAULT token support in RightCurlyCheck#19037vivek-0509 wants to merge 1 commit intocheckstyle:masterfrom
vivek-0509 wants to merge 1 commit intocheckstyle:masterfrom
Conversation
Contributor
Author
|
GitHub, generate website |
Contributor
Author
|
GitHub, generate report |
Contributor
Author
|
@romani I have reviewed the diff report all the violations are genuine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix false-negative for LITERAL_DEFAULT token in RightCurlyCheck
Issue #14782:
LITERAL_DEFAULTtoken support inRightCurlyCheckLITERAL_DEFAULTto Google style configuration (google_checks.xml)LITERAL_DEFAULT#14782false-negative reference fromgoogle_style.xmlcoverage pageDiff Regression config: https://gist.githubusercontent.com/vivek-0509/de0e36db6f5b68a6a617acbe7e5312ea/raw/ffbe0df1852c6a3038a056c0134c108a7e431611/base_config.xml
Diff Regression patch config: https://gist.githubusercontent.com/vivek-0509/d0238b505bbd2e8c3eaf35291cb96ca8/raw/1e96218808d7e4166f1fcb77eb7364cd5a29f726/patch_config.xml