Issue #16807: remove MemberNameCheck from SUPPRESSED_MODULES#19044
Merged
romani merged 1 commit intocheckstyle:masterfrom Mar 9, 2026
Merged
Issue #16807: remove MemberNameCheck from SUPPRESSED_MODULES#19044romani merged 1 commit intocheckstyle:masterfrom
romani merged 1 commit intocheckstyle:masterfrom
Conversation
Contributor
Author
|
CI failure are unrelated |
Contributor
|
Hello @Hajime-No-Ippo |
Contributor
Author
|
Thanks for telling, working on it |
2eb5842 to
d0d12c5
Compare
d0d12c5 to
ac75a23
Compare
Contributor
Author
|
@romani Hi sir, I had finish the clean up the suppression module, and it is ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

issue #16807.
PR Summary — Issue #16807: Remove MemberNameCheck from
SUPPRESSED_MODULES
What This PR Does
All input test files that reference MemberNameCheck now have every default property explicitly listed with the (default) tag. Because the files are already compliant (According to the issue#16807), the suppression is no longer needed.
The changes fall into 3 categories:
MemberNameCheck is removed from SUPPRESSED_MODULES, enabling validateDefaultProperties() to run on all input files that use this module.
InputSuppressWarningsHolder8.java — was missing the (default) tag on format and missing all 4 applyTo* properties entirely.
InputTreeWalkerSuppressionCommentFilter.java — was missing all 4 applyTo* properties entirely.
Both files now declare all 5 default properties for MemberNameCheck:
Adding those properties to the file headers shifted the Java code inside each input file to new line numbers. The corresponding tests have hardcoded violation line numbers that must match:
4 lines)
(header grew by 5 lines)