Update handling of windows timezone to account for usage of dword/signed integers by vCenter 8#190
Open
lomeroe wants to merge 6 commits into
Open
Update handling of windows timezone to account for usage of dword/signed integers by vCenter 8#190lomeroe wants to merge 6 commits into
lomeroe wants to merge 6 commits into
Conversation
…tegers by vCenter 8 vCenter 8 expects signed integer versions of the timezone hex values, i.e. 0x80000050 (UTC timezone) when converted to an integer should be "-2147483568" not "2147483728"
Signed-off-by: lomeroe <github@moorefam5.com>
Signed-off-by: lomeroe <github@moorefam5.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vCenter 8 expects dword/signed integer versions of the timezone hex values for windows, i.e. 0x80000050 (UTC time) when converted to an integer should be "-2147483568" not "2147483728" as the basic "to_i" returns
This PR allows specifying negative integer numbers as well as properly converting hex values. Additionally, if either type is passed as a string representation, the value is properly converted.
Description
When attempting to customize a Windows VM's timezone, the use of "0x80000050" (as an example) no longer properly sets the timezone to "UTC". vCenter expects the a signed integer version, where 0x8000050 is -2147483568.
Related Issue
#189
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.