refactor: change useForm on AlignSpectra - #4324
Merged
Merged
Conversation
Deploying nmrium with
|
| Latest commit: |
3717583
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://49cf5dc1.nmrium.pages.dev |
| Branch Preview URL: | https://4192-refactor-useform-on-ali.nmrium.pages.dev |
tpoisseau
reviewed
Aug 25, 2026
tpoisseau
left a comment
tpoisseau
left a comment
Contributor
There was a problem hiding this comment.
Please explain how to show this form in nmrium.
Collaborator
Author
|
Go on localhost, open XTC Multiple spectra, open "Multiple Spectra Analysis Panel" then click on the second icon |
tpoisseau
reviewed
Aug 25, 2026
tpoisseau
left a comment
tpoisseau
left a comment
Contributor
There was a problem hiding this comment.
There is an issue with scrolling, the content overflow but no scrolling, no scrollbar.
To show all the form fields, I need to fold spectra panel to see the rest of the form.
I though submit button was missing but I saw it in the source code.
Collaborator
Author
|
Ok, i think removing the inner container class looks good on this case. Tell me if its not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #4192