Skip to content

fix: ignore changes to import files inside addons for updates#208

Open
andersmmg wants to merge 2 commits intochickensoft-games:mainfrom
andersmmg:ignore-import-data
Open

fix: ignore changes to import files inside addons for updates#208
andersmmg wants to merge 2 commits intochickensoft-games:mainfrom
andersmmg:ignore-import-data

Conversation

@andersmmg
Copy link
Copy Markdown
Contributor

Fixes #202 in my testing, just depends if this should be default or an optional thing?

@wlsnmrk
Copy link
Copy Markdown
Contributor

wlsnmrk commented Jan 19, 2026

Thanks for putting this together! Looks like a reasonable approach to me.

Would you be willing to add a test verifying the creation of the file? It could probably be expressed as another expected call to client in the existing AddonsRepository test named InstallAddonFromCacheCopiesCachedAddonToAddonsPath.

(Aside: @jolexxa, I don't think we need to address this in this PR, and no one's complained about it yet, but at some point we may need to consider how we're going to handle .import files in symlink addons.)

@wlsnmrk
Copy link
Copy Markdown
Contributor

wlsnmrk commented Jan 19, 2026

To address your question: I lean toward "this should be optional behavior." If the addon author did commit their .import files and then you've changed the import settings locally, you might want to be alerted to that fact. @jolexxa Any thoughts?

@andersmmg
Copy link
Copy Markdown
Contributor Author

I can add a cli argument to enable this, I'm thinking "--ignore-imports" or something similar. I added to the test, lmk if I did that right for how it works now, I can make it conditional as well if I add the argument though. Another thought I had, what if an addon has a .gitignore included in it? Should it just add *.import to it?

@jolexxa
Copy link
Copy Markdown
Member

jolexxa commented Jan 21, 2026

Another thought I had, what if an addon has a .gitignore included in it? Should it just add *.import to it?

Yes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to ignore .import file changes?

3 participants