fix: ignore changes to import files inside addons for updates#208
fix: ignore changes to import files inside addons for updates#208andersmmg wants to merge 2 commits intochickensoft-games:mainfrom
Conversation
|
Thanks for putting this together! Looks like a reasonable approach to me. Would you be willing to add a test verifying the creation of the file? It could probably be expressed as another expected call to (Aside: @jolexxa, I don't think we need to address this in this PR, and no one's complained about it yet, but at some point we may need to consider how we're going to handle |
|
To address your question: I lean toward "this should be optional behavior." If the addon author did commit their |
|
I can add a cli argument to enable this, I'm thinking "--ignore-imports" or something similar. I added to the test, lmk if I did that right for how it works now, I can make it conditional as well if I add the argument though. Another thought I had, what if an addon has a .gitignore included in it? Should it just add *.import to it? |
Yes :) |
Fixes #202 in my testing, just depends if this should be default or an optional thing?