fix: handle pre-aborted fetch signals#19
Merged
Conversation
Signed-off-by: Aysajan Eziz <aeziz@northset.ai>
Collaborator
|
Good catch, this closes a real race with the new stop-voice control. Verified the guard and the test locally. Thanks! |
Contributor
Author
|
Thank you for verifying it locally and for the merge — glad the guard closes that race. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handle a caller signal that is already aborted when fetchWithTimeout starts, with a focused regression for the pre-aborted path.
Change
client/src/__tests__/utils/fetchWithTimeout.test.tsclient/src/utils/fetchWithTimeout.tsChecks
corepack pnpm@8.15.5 --dir client test:unit -- src/__tests__/utils/fetchWithTimeout.test.ts— passed in a network-isolated container.corepack pnpm@8.15.5 --dir client exec tsc --noEmit— passed in a network-isolated container.corepack pnpm@8.15.5 --dir client build:client— passed in a network-isolated container.Fixes #17
AI assistance was used; I reviewed and own this change.
Verification
the repository's declared test command exited 0 on this exact head (
5fbd2c8) in a network-off container, before this PR was opened.Commands, environment, and hashes: receipt M-106 — checkable in ~30 seconds without trusting us.
This record covers Northset's own contribution; it is not maintainer verification.
Maintainers: request a separate private run for any PR in your queue — open a run request: https://github.com/northset-oss/verification-pilot/issues/new?template=request-a-run.yml or email oss@northset.ai.
For repositories already onboarded with Northset, adding
northset-verifyto a PR requests a run on that PR.