Fix integration tests for SearchResult API#62
Closed
chrislyonsKY wants to merge 4 commits into
Closed
Conversation
- Use hasattr for reader.close() (not available in all laspy versions) - Execute notebook against live KyFromAbove data with real output: DEM COG, ortho COG, COPC point cloud, rio-cogeo deep validation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Tests used GeoDataFrame methods (.iloc, .columns) directly on SearchResult objects. Updated to access underlying GeoDataFrame via .tiles property. Also skip laz_phase1 on STAC data gaps and guard mosaic test behind osgeo availability. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 2 high |
🟢 Metrics 0 complexity · 0 duplication
Metric Results Complexity 0 Duplication 0
TIP This summary will be updated as you push new changes. Give us feedback
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Owner
Author
|
Replaced by new PR from fix/integration-tests branch (code scanning rule blocked pushes to original branch) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
search()returningSearchResultinstead of rawGeoDataFrame.iloc/.columnscalls with.tiles.iloc/.tiles.columnsto access underlying GeoDataFramelaz_phase1test when STAC has no data in Frankfort bbox (data gap, not a code bug)test_mosaic_vrtbehindpytest.importorskip("osgeo")for CI envs without GDALTest plan
🤖 Generated with Claude Code