Merged
Conversation
…tead) to support multiple room event tracking of the same event
…/leaves within the space
…a visual of call activity and participants
…be the best approach, but removes code replication in PersistentCallContainer where we were remaking the roomview entirely)
…calls (for viewing their text channels)
…ontainer more directly
… and made more direct use of the ref
|
My testing on Firefox and bazzite has been putting all of the audio in the right channel only. Not sure if this is a Firefox audio bug or something with the web bindings for audio in cinny. |
|
Can confirm I only have sound on one side on Firefox. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #528
Revives and continues #2335 (Element Call support), as the original PR has stalled.
Merged
devinto this branch, resolved conflicts, and incorporated patches from @YoJames2019 to bring everything up to date and reviewable.Credits to @GigiaJ for the original implementation and @YoJames2019 for follow up patches.
Here's laundry list of things I feel like should be addressed before merging: (Feedback welcome!)
Need to fix (help would be appreciated):
Nice to haves:
Type of change
Checklist:
Test build: https://2680--pr-cinny.netlify.app/