feature: display tag icons in members drawer#2700
feature: display tag icons in members drawer#2700malwarepad wants to merge 2 commits intocinnyapp:devfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Preview: https://2700--pr-cinny.netlify.app |
| className={classNames(css.MembersGroupLabel, css.DrawerVirtualItem)} | ||
| size="L400" | ||
| > | ||
| {tagIconSrc && <PowerIcon size="100" iconSrc={tagIconSrc} />} |
There was a problem hiding this comment.
I think it looks much better if we display the tag after role name. Otherwise it feels like it's another user in there.
There was a problem hiding this comment.
I think it looks much better if we display the tag after role name. Otherwise it feels like it's another user in there.
Even though that makes sense in a chat context (since its besides a user, and that user has a pfp), having the icon after the tag looks really bad on the sidebar. Other than role name width inconsistencies, it looks weird having the pfp & tag icons on opposite sides. Also there is a pretty big distinction between user pfps & tag icons, since the text size and icon sizes are vastly different.
There was a problem hiding this comment.
Well.. tags inside room timeline also after username, also in settings they are after role name so I think a little consistency would be better.
@malwarepad Hi, how does it sounds?
2 participants
Description
Adds the tag icon (if one exists) on the left of the text in the members list. It is a small visual change but with enough power levels, it looks really really cool.
Type of change
Checklist:
Small preview (before vs after):