⚠️ CONFLICT! Lineage pull request for: skeleton#64
Merged
Conversation
Previously we only provided a lower bound for the version, but pinning to a specific version aligns with what has been done with the prettier hook and how pre-commit hooks are pinned in general. The flake8-docstrings package is rarely updated, so there is no real downside to pinning to a specific version. Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3...v4) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [crazy-max/ghaction-github-status](https://github.com/crazy-max/ghaction-github-status) from 3 to 4. - [Release notes](https://github.com/crazy-max/ghaction-github-status/releases) - [Commits](crazy-max/ghaction-github-status@v3...v4) --- updated-dependencies: - dependency-name: crazy-max/ghaction-github-status dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
This is done automatically with the `pre-commit autoupdate` command. The pre-commit/mirrors-prettier hook was manually held back because the latest tags are for alpha releases of the next major version.
Use the latest v3 release available from NPM.
…max/ghaction-github-status-4 Bump crazy-max/ghaction-github-status from 3 to 4
…s/cache-4 Bump actions/cache from 3 to 4
Use an Action to install Packer in our GitHub Actions workflows
…hon-version-checks Add checks for correct semantic version of Python
Remove @jasonodoom as a codeowner
The pip-audit tool will audit any supplied pip requirements files for vulnerable packages.
…hook Add the `check-useless-excludes` hook to the pre-commit configuration
…mmit_hook Add a pre-commit hook to run `pip-audit`
Add a lower-bound pin for the `flake8-docstrings` `pip` package
Update `pre-commit` hooks
This replaces the now archived pre-commit/mirrors-prettier hook.
Switch the `pre-commit` hook used to run `prettier`
Copy over necessary changes from the `bump_version.sh` script.
This functionality has been replaced by the `bump-version` script.
Add a `workflow_dispatch` trigger so we can manually run the workflow if needed.
This Action will provide information about the usage of GITHUB_TOKEN in the workflow. It should be added to _every_ job in _any_ workflow to provide information for analysis.
This changes the default permissions for the GITHUB_TOKEN used in our GitHub Actions configuration to the minimum required to successfully run.
This is done automatically with the `pre-commit autoupdate` command.
Ensure that all hook ids are sorted alphabetically in each hook entry in our pre-commit configuration.
…bels_workflow Allow the `sync-labels` workflow to be run manually
…ons-monitor Add the `GitHubSecurityLab/actions-permissions/monitor` Action
Explicitly define permissions of `GITHUB_TOKEN` in our GitHub Actions workflows
Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.32.0 to 0.33.0. - [Release notes](https://github.com/aquasecurity/trivy-action/releases) - [Commits](aquasecurity/trivy-action@0.32.0...0.33.0) --- updated-dependencies: - dependency-name: aquasecurity/trivy-action dependency-version: 0.33.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
ae988be to
c8e139d
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This is a Lineage pull request that incorporates upstream changes from the skeleton-docker repository to keep the guacamole-composition project synchronized with the latest skeleton template updates.
- Updates the version format from Python-style to plain semantic versioning
- Replaces the old bump_version.sh script with a new bump-version script that provides better functionality
- Updates various configuration files, dependencies, and GitHub Actions workflows to their latest versions
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| trivy.yml | Adds new Trivy security scanner configuration |
| tests/container_test.py | Removes shebang line from test file |
| tests/conftest.py | Adds project version fixture and constant |
| tag.sh | Updates script name reference from bump_version.sh to bump-version |
| src/version.txt | Changes version format from Python-style to plain semantic version |
| setup-env | Major update with enhanced argument parsing and Python version validation |
| requirements-test.txt | Adds semver dependency for version management |
| requirements-dev.txt | Removes semver dependency and adds pipenv |
| compose.yml | Removes deprecated version field and updates port syntax |
| bump_version.sh | Removes old version management script |
| bump-version | Adds new enhanced version management script |
| README.md | Updates badge URL and removes Snyk vulnerability badge |
| CONTRIBUTING.md | Updates documentation for GNU getopt requirement |
| .yamllint | Adds comprehensive YAML linting rules |
| .prettierignore | Adds *.lock to ignored files |
| .pre-commit-config.yaml | Updates hook versions and adds new security checks |
| .mdl_config.yaml | Updates YAML quoting style |
| .github/workflows/* | Updates GitHub Actions workflows with latest versions and security improvements |
| .github/lineage.yml | Fixes YAML quoting style |
| .github/labels.yml | Updates label color definitions |
| .github/dependabot.yml | Updates dependency management configuration |
| .github/CODEOWNERS | Updates code ownership assignments |
Comments suppressed due to low confidence (1)
setup-env:1
- The
+=operator for string concatenation in bash is not POSIX compliant and may not work in all shell environments. Consider using explicit concatenation:local prerelease="${prerelease}(?:0|[1-9]..."or define the full string in one assignment.
#!/usr/bin/env bash
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
dv4harr10
approved these changes
Sep 3, 2025
jsf9k
requested changes
Sep 3, 2025
We use the `bandit` hook twice in the pre-commit configuration: once for the `tests/` subdirectory and once for everything _except_ the `tests/` subdirectory. These two hooks should be using the same version of the `bandit` hook, but the second use was missed when updating hook versions from upstream.
dav3r
approved these changes
Sep 3, 2025
jsf9k
approved these changes
Sep 3, 2025
…s/download-artifact-5 Bump actions/download-artifact from 4 to 5
…curity/trivy-action-0.33.0 Bump aquasecurity/trivy-action from 0.32.0 to 0.33.0
Sync the versions of `bandit` used by pre-commit
This project does not display its version in the README so there is no reason to have the `bump-version` script attempt to update it when bumping the version.
1356b01 to
b808cd9
Compare
jsf9k
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lineage Pull Request: CONFLICT
Lineage has created this pull request to incorporate new changes found in an
upstream repository:
Upstream repository:
https://github.com/cisagov/skeleton-docker.gitRemote branch:
HEADCheck the changes in this pull request to ensure they won't cause issues with
your project.
The
lineage/skeletonbranch has one or more unresolved merge conflictsthat you must resolve before merging this pull request!
How to resolve the conflicts
Take ownership of this pull request by removing any other assignees.
Clone the repository locally, and reapply the merge:
Review the changes displayed by the
statuscommand. Fix any conflicts andpossibly incorrect auto-merges.
After resolving each of the conflicts,
addyour changes to thebranch,
commit, andpushyour changes:Note that you may append to the default merge commit message
that git creates for you, but please do not delete the existing
content. It provides useful information about the merge that is
being performed.
Wait for all the automated tests to pass.
Confirm each item in the "Pre-approval checklist" below.
Remove any of the checklist items that do not apply.
Ensure every remaining checkbox has been checked.
Mark this draft pull request "Ready for review".
✅ Pre-approval checklist
Remove any of the following that do not apply. If you're unsure about
any of these, don't hesitate to ask. We're here to help!
to reflect the changes in this PR.
Note
You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.
For more information:
🛠 Lineage configurations for this project are stored in
.github/lineage.yml📚 Read more about Lineage